Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update peer dependencies for platform fastify and update sample #14436

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix: update peer dependencies for platform fastify and update sample #14436

merged 2 commits into from
Jan 17, 2025

Conversation

Tony133
Copy link
Contributor

@Tony133 Tony133 commented Jan 16, 2025 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number:
#14437

What is the new behavior?

Proposal:

In the peerDependencies section of the package.json of the @nestjs/platform-fastify package the @nestjs/common package and @nestjs/core package, are still at version 10.0.0, they should be updated to v11.0.0 🔥

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Jan 16, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 9199914b-23d8-4c5e-a285-7bf8c9accc72

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.696%
Totals Coverage Status
Change from base Build ca8ad63e-cd39-4bb7-83a7-a7d4c7311eab: 0.0%
Covered Lines: 7103
Relevant Lines: 7919
💛 - Coveralls

@Tony133 Tony133 mentioned this pull request Jan 17, 2025
Closed
15 tasks
@Tony133 Tony133 force-pushed the fix/update-peer-dependencies-for-platform-fastify branch from a8cdda2 to 63fb393 Compare January 17, 2025 07:54
@Tony133
Copy link
Contributor Author

Tony133 commented Jan 17, 2025

I also updated the package.json of some examples so we can see if the CI pipeline works, see commit here:
63fb393

@Tony133 Tony133 changed the title fix: update peer dependencies for platform fastify fix: update peer dependencies for platform fastify and update sample Jan 17, 2025
@Tony133 Tony133 force-pushed the fix/update-peer-dependencies-for-platform-fastify branch from 63fb393 to 2ee3853 Compare January 17, 2025 08:01
@Tony133
Copy link
Contributor Author

Tony133 commented Jan 17, 2025 •
edited
Loading

think you have to publish the @nestjs/cli v11.x package, otherwise I think the CI pipeline fails

@kamilmysliwiec
Copy link
Member

Let me revert it to 10.4.9 for now. Thank you @Tony133!

@kamilmysliwiec kamilmysliwiec merged commit 6dcb57f into nestjs:master Jan 17, 2025
4 of 5 checks passed
@Tony133 Tony133 mentioned this pull request Jan 18, 2025
Closed
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tony133 @coveralls @kamilmysliwiec